improve logging #402
Draft
improve logging #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hweihwang
force-pushed
the
fix/improve-logging
branch
2 times, most recently
from
9201591 to
fcefdab
Compare
Signed-off-by: Hoang Pham <[email protected]>
hweihwang
force-pushed
the
fix/improve-logging
branch
from
fcefdab to
f6d74f0
Compare
|
Most places that log as warning should probably be rather info or debug level |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% cover the cases, can be improved a lot, just in-need for some support cases now